Skip to content

fuzz: do not use inherits in Cargo.toml #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2021
Merged

fuzz: do not use inherits in Cargo.toml #817

merged 1 commit into from
Nov 17, 2021

Conversation

catenacyber
Copy link
Contributor

BurntSushi
BurntSushi approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@BurntSushi BurntSushi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! If you don't mind me asking, how did you debug this? I remember looking at the fuzz failure, and it wanted me to do a song-and-a-dance to debug it and I didn't have time to dig into it. And also, what was wrong with using inherits here?

@catenacyber
Copy link
Contributor Author

I looked at the ailing build log
https://oss-fuzz-build-logs.storage.googleapis.com/log-c9b61873-8950-4a50-a729-820d5617ff7a.txt

Step #3 - "compile-libfuzzer-address-x86_64": error: inherits must not be specified in root profile dev

I tried looking for inherits in cargo's doc but did not find any mention

@BurntSushi BurntSushi merged commit 5197f21 into rust-lang:master Nov 17, 2021
@BurntSushi
Copy link
Member

Perfect. That sounds like a much better commit message. :-) I've copied it into the message.

@catenacyber
Copy link
Contributor Author

Thanks for rewording the commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catenacyber @BurntSushi